AmatyaAvadhanula commented on code in PR #16614:
URL: https://github.com/apache/druid/pull/16614#discussion_r1650301407
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BaseAppenderatorDriver.java:
##########
@@ -274,7 +275,7 @@ Stream<SegmentsOfInterval> getAllSegmentsOfInterval()
{
this.appenderator = Preconditions.checkNotNull(appenderator,
"appenderator");
this.segmentAllocator = Preconditions.checkNotNull(segmentAllocator,
"segmentAllocator");
- this.usedSegmentChecker = Preconditions.checkNotNull(usedSegmentChecker,
"usedSegmentChecker");
+ this.usedSegmentChecker = Preconditions.checkNotNull(usedSegmentChecker,
"segmentRetriever");
Review Comment:
Please rename this variable to segmentRetriever
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TaskAction.java:
##########
@@ -38,9 +38,8 @@
@JsonSubTypes.Type(name = "segmentTransactionalInsert", value =
SegmentTransactionalInsertAction.class),
@JsonSubTypes.Type(name = "segmentTransactionalAppend", value =
SegmentTransactionalAppendAction.class),
@JsonSubTypes.Type(name = "segmentTransactionalReplace", value =
SegmentTransactionalReplaceAction.class),
- // Type name doesn't correspond to the name of the class for backward
compatibility.
+ @JsonSubTypes.Type(name = "segmentListById", value =
RetrieveSegmentsByIdAction.class),
Review Comment:
Nit: Please rename type name to "retrieveSegmentsById" since there is no
need to maintain backward compatibility for this action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
