AmatyaAvadhanula commented on code in PR #16614:
URL: https://github.com/apache/druid/pull/16614#discussion_r1650317128
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TaskAction.java:
##########
@@ -38,9 +38,8 @@
@JsonSubTypes.Type(name = "segmentTransactionalInsert", value =
SegmentTransactionalInsertAction.class),
@JsonSubTypes.Type(name = "segmentTransactionalAppend", value =
SegmentTransactionalAppendAction.class),
@JsonSubTypes.Type(name = "segmentTransactionalReplace", value =
SegmentTransactionalReplaceAction.class),
- // Type name doesn't correspond to the name of the class for backward
compatibility.
+ @JsonSubTypes.Type(name = "segmentListById", value =
RetrieveSegmentsByIdAction.class),
Review Comment:
The names are supposed to be consistent with the task action
The comment that was moved indicates that certain actions have a different
key than the name because of backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
