kgyrtkirk commented on code in PR #16700: URL: https://github.com/apache/druid/pull/16700#discussion_r1668453034
########## processing/src/main/java/org/apache/druid/segment/SimpleQueryableIndex.java: ########## @@ -46,8 +47,8 @@ public class SimpleQueryableIndex implements QueryableIndex private final BitmapFactory bitmapFactory; private final Map<String, Supplier<ColumnHolder>> columns; private final SmooshedFileMapper fileMapper; - @Nullable - private final Metadata metadata; + @NotNull + private final Supplier<Metadata> metadataSupplier; Review Comment: this doesn't seem right; why soften `Metadata` with a `Supplier` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
