imply-cheddar commented on PR #16700: URL: https://github.com/apache/druid/pull/16700#issuecomment-2216545237
Looking at the failures, this needs improved coverage. For `SemanticUtils`, it should be fine to create a class like inside of `SemanticUtilsTest.ClassForSemanticUtilsCoverage` that you then register implementations against and run things. This should allow you to validate capabilities without the static nature of the internal object becoming an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
