clintropolis commented on code in PR #16653:
URL: https://github.com/apache/druid/pull/16653#discussion_r1669861537
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java:
##########
@@ -492,11 +492,26 @@ static Supplier<Object> supplierFromObjectSelector(
return val;
}
};
+ } else if (clazz.isAssignableFrom(Object[].class)) {
+ return () -> {
+ final Object val = selector.getObject();
+ if (val != null) {
+ NonnullPair<ExpressionType, Object[]> coerced =
ExprEval.coerceListToArray(
+ Arrays.asList((Object[]) val),
+ homogenizeMultiValue
Review Comment:
wait, actual arrays should _never_ be coerced, this is strictly for
multi-value strings, why do we need to coerce here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
