clintropolis commented on code in PR #16653:
URL: https://github.com/apache/druid/pull/16653#discussion_r1680327406
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java:
##########
@@ -475,15 +475,15 @@ static Supplier<Object> supplierFromObjectSelector(
}
final Class<?> clazz = selector.classOfObject();
- if (Number.class.isAssignableFrom(clazz) ||
String.class.isAssignableFrom(clazz)) {
- // Number, String supported as-is.
+ if (Number.class.isAssignableFrom(clazz) ||
String.class.isAssignableFrom(clazz) || Object[].class.isAssignableFrom(clazz))
{
Review Comment:
i suppose this would have also ended up in the 'else' case, but this seems
fine too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
