LakshSingla commented on code in PR #16714:
URL: https://github.com/apache/druid/pull/16714#discussion_r1671929293
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByQueryEngine.java:
##########
@@ -219,16 +220,16 @@ private static boolean hasNoImplicitUnnestDimensions(
}
if (dimension.getOutputType().isArray()) {
- return false;
+ continue;
}
// Now check column capabilities, which must be present and explicitly
not multi-valued and not arrays
final ColumnCapabilities capabilities =
inspector.getColumnCapabilities(dimension.getDimension());
- if (capabilities != null && capabilities.hasMultipleValues().isFalse()
&& !capabilities.isArray()) {
+ if (capabilities != null &&
capabilities.hasMultipleValues().isMaybeTrue() && !capabilities.isArray()) {
return false;
}
}
- return true;
+ return !hasImplicitUnnest;
Review Comment:
`hasImplicitUnnest` is always false?
##########
processing/src/main/java/org/apache/druid/segment/VirtualColumns.java:
##########
@@ -59,7 +59,7 @@
/**
* Class allowing lookup and usage of virtual columns.
*/
-public final class VirtualColumns implements Cacheable
+public class VirtualColumns implements Cacheable
Review Comment:
qq: Why are we reverting this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
