clintropolis commented on code in PR #16714: URL: https://github.com/apache/druid/pull/16714#discussion_r1673337978
########## processing/src/main/java/org/apache/druid/segment/VirtualColumns.java: ########## @@ -59,7 +59,7 @@ /** * Class allowing lookup and usage of virtual columns. */ -public final class VirtualColumns implements Cacheable +public class VirtualColumns implements Cacheable Review Comment: oh, I didn't really mean to push it in the first place. I thought about it briefly, but then was thinking that it might be nice to someday split out `VirtualColumns` with "dot" support from `VirtualColumns` without it, so that we don't have to check every `getVirtualColumn` call to see if it contains a `.` to split on and check the "dot" virtual columns. These are not used by built-in virtual column implementations, only some extensions, so I think we could specialize implementations a bit to only do this stuff if we detect any `VirtualColumn.usesDotNotation` that return true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
