kfaraz commented on code in PR #16291:
URL: https://github.com/apache/druid/pull/16291#discussion_r1672109003
##########
server/src/main/java/org/apache/druid/server/coordinator/compact/CompactionStatus.java:
##########
@@ -305,17 +305,30 @@ private CompactionStatus metricsSpecIsUpToDate()
if (ArrayUtils.isEmpty(configuredMetricsSpec)) {
return COMPLETE;
}
+ final AggregatorFactory[] configuredMetricsCombiningFactorySpec =
Review Comment:
I would advise retaining the old version of the code and doing this change
in a follow up. In the current PR, I would prefer it if we didn't modify any of
the logic for native compaction. What happens if we just stick to the old logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
