gargvishesh commented on code in PR #16291:
URL: https://github.com/apache/druid/pull/16291#discussion_r1673446953


##########
server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java:
##########
@@ -83,6 +84,7 @@ public void testSerdeBasic() throws IOException
     Assert.assertEquals(config.getTuningConfig(), fromJson.getTuningConfig());
     Assert.assertEquals(config.getTaskContext(), fromJson.getTaskContext());
     Assert.assertEquals(config.getGranularitySpec(), 
fromJson.getGranularitySpec());
+    Assert.assertEquals(config.getEngine(), fromJson.getEngine());

Review Comment:
   The engine will be null as the override with default happens at the 
submission time only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to