AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1673629926
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -587,6 +587,12 @@ protected void alterSegmentTable()
Map<String, String> columnNameTypes = new HashMap<>();
columnNameTypes.put("used_status_last_updated", "VARCHAR(255)");
+ // upgraded_from_segment_id is the first segment to which the same load
spec originally belonged
+ // Load specs can be shared as a result of segment version upgrade
Review Comment:
Removed
##########
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java:
##########
@@ -138,16 +138,19 @@ public void testCommitAppendSegments()
final String v1 = "2023-01-01";
final String v2 = "2023-01-02";
final String v3 = "2023-01-03";
+ final String alreadyUpgradedVersion = "2023-02-01";
final String lockVersion = "2024-01-01";
- final String replaceTaskId = "replaceTask1";
+ final String taskAllocatorId = "appendTask";
+ final String replaceTaskId = "replaceTask";
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
