kfaraz commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1673817218
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1540,6 +1551,48 @@ int insertPendingSegmentsIntoMetastore(
return Arrays.stream(updated).sum();
}
+ @VisibleForTesting
+ public void insertUsedSegments(Set<DataSegment> dataSegments, Map<SegmentId,
String> upgradedFromSegmentIdMap)
Review Comment:
Could you please elaborate?
As a last resort, duplication in tests is fine but we shouldn't have to
include unnecessary logic in classes as it makes the code confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
