Akshat-Jain commented on code in PR #16682:
URL: https://github.com/apache/druid/pull/16682#discussion_r1677515072
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/sql/ThetaSketchBaseSqlAggregator.java:
##########
@@ -116,26 +121,38 @@ public Aggregation toDruidAggregation(
);
}
- final DimensionSpec dimensionSpec;
-
- if (columnArg.isDirectColumnAccess()) {
- dimensionSpec = columnArg.getSimpleExtraction().toDimensionSpec(null,
inputType);
- } else {
- String virtualColumnName =
virtualColumnRegistry.getOrCreateVirtualColumnForExpression(
- columnArg,
- dataType
+ if (!inputType.is(ValueType.COMPLEX)) {
Review Comment:
Where? Do you mean the following?
```java
if (!inputType.is(ValueType.COMPLEX)) {
// code
}
else {
plannerContext.setPlanningError(xyz);
return null;
}
```
If yes, this would run into the same duplication reasoning as the other
comments: https://github.com/apache/druid/pull/16682#discussion_r1677509084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
