Akshat-Jain commented on code in PR #16682:
URL: https://github.com/apache/druid/pull/16682#discussion_r1674121332
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/BuiltinApproxCountDistinctSqlAggregator.java:
##########
@@ -177,4 +177,10 @@ private static class
BuiltinApproxCountDistinctSqlAggFunction extends SqlAggFunc
);
}
}
+
+ private boolean validateInputComplexTypeName(ColumnType columnType)
+ {
+ return Objects.equals(columnType.getComplexTypeName(),
HyperUniquesAggregatorFactory.TYPE.getComplexTypeName()) ||
+ Objects.equals(columnType.getComplexTypeName(),
HyperUniquesAggregatorFactory.PRECOMPUTED_TYPE.getComplexTypeName());
Review Comment:
I'm not sure on this. Will check with Clint / Zoltan on all the pending
review comments where I'm lacking context to make a decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
