lorem--ipsum commented on code in PR #16749:
URL: https://github.com/apache/druid/pull/16749#discussion_r1681616022
##########
web-console/src/views/workbench-view/max-tasks-button/max-tasks-button.tsx:
##########
@@ -40,14 +40,28 @@ const TASK_ASSIGNMENT_DESCRIPTION: Record<string, string> =
{
auto: `Use as few tasks as possible without exceeding 512 MiB or 10,000
files per task, unless exceeding these limits is necessary to stay within
'maxNumTasks'. When calculating the size of files, the weighted size is used,
which considers the file format and compression format used if any. When file
sizes cannot be determined through directory listing (for example: http),
behaves the same as 'max'.`,
};
+const DEFAULT_MAX_NUM_LABEL_FN = (maxNum: number) => {
+ if (maxNum === 2) return { text: 'Auto', label: '(1 controller + 1 worker)'
};
+ return { text: 'Auto', label: `(1 controller + max ${maxNum - 1} workers)` };
Review Comment:
oh wow yes, thanks for catching that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
