kgyrtkirk commented on code in PR #16781:
URL: https://github.com/apache/druid/pull/16781#discussion_r1687676746
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -230,6 +229,13 @@ public QueryDefinition makeQueryDefinition(
partitionColumnNames
);
+ // We need to pass only the window factories for the window stage
definition.
+ // Sorting and partitioning are expected to be handled by the shuffle
spec of the previous stage.
+ final List<OperatorFactory> windowOperatorList = operatorList.get(i)
+ .stream()
+
.filter(operator -> operator instanceof WindowOperatorFactory)
Review Comment:
this is not necessarily true - I don't believe in building an infrastrucutre
which could only do partitioning/shuffle in-between stages
there are benefits of further partitioning an existing sort; and that's
rather cheap....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
