Akshat-Jain commented on code in PR #16780:
URL: https://github.com/apache/druid/pull/16780#discussion_r1687858390
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -103,13 +107,17 @@ public WindowOperatorQueryFrameProcessor(
this.frameWriterFactory = frameWriterFactory;
this.operatorFactoryList = operatorFactoryList;
this.jsonMapper = jsonMapper;
- this.frameReader = frameReader;
this.query = query;
this.frameRowsAndCols = new ArrayList<>();
this.resultRowAndCols = new ArrayList<>();
this.objectsOfASingleRac = new ArrayList<>();
this.maxRowsMaterialized = maxRowsMaterializedInWindow;
this.partitionColumnNames = partitionColumnNames;
+
+ this.frameReader = frameReader;
+ for (int i = 0; i < frameReader.signature().size(); i++) {
+
typeStrategies.add(frameReader.signature().getColumnType(i).get().getNullableStrategy());
Review Comment:
I haven't stumbled upon a case where the column type wasn't present, yet. I
thought I'll add an explicit check if we stumble upon such a case in this layer
in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
