cryptoe commented on code in PR #16779:
URL: https://github.com/apache/druid/pull/16779#discussion_r1692788282
##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -57,6 +57,19 @@ on:
AWS_SECRET_ACCESS_KEY:
required: false
type: string
+ BACKWARD_INCOMPATIBILITY_IT_ENABLED:
+ required: false
+ type: string
+ default: false
+ DRUID_PREVIOUS_VERSION:
+ required: false
+ type: string
+ DRUID_PREVIOUS_VERSION_DOWNLOAD_URL:
+ required: false
+ type: string
+ DRUID_PREVIOUS_IT_IMAGE_NAME:
Review Comment:
I think we can remove this image name. We can easily derive it from the
`DRUID_PREVIOUS_VERSION`
##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -57,6 +57,19 @@ on:
AWS_SECRET_ACCESS_KEY:
required: false
type: string
+ BACKWARD_INCOMPATIBILITY_IT_ENABLED:
Review Comment:
I think we can remove this as well. If druid previous version is null, we
can just skip running the backward compatibility it.
##########
integration-tests-ex/cases/cluster/Common/dependencies.yaml:
##########
@@ -26,7 +26,7 @@ services:
# See https://hub.docker.com/_/zookeeper
zookeeper:
# Uncomment the following when running on Apple Silicon processors:
- # platform: linux/x86_64
+ platform: linux/x86_64
Review Comment:
why is this required?
##########
integration-tests-ex/image/docker/Dockerfile:
##########
@@ -46,13 +46,15 @@ ARG MARIADB_VERSION
ENV MARIADB_VERSION=$MARIADB_VERSION
ARG MYSQL_DRIVER_CLASSNAME=com.mysql.jdbc.Driver
ENV MYSQL_DRIVER_CLASSNAME=$MYSQL_DRIVER_CLASSNAME
+ARG DRUID_TESTING_TOOLS_VERSION
+ENV DRUID_TESTING_TOOLS_VERSION=$DRUID_TESTING_TOOLS_VERSION
ENV DRUID_HOME=/usr/local/druid
# Populate build artifacts
COPY apache-druid-${DRUID_VERSION}-bin.tar.gz /usr/local/
-COPY druid-it-tools-${DRUID_VERSION}.jar /tmp/druid/extensions/druid-it-tools/
+COPY druid-it-tools-${DRUID_TESTING_TOOLS_VERSION}.jar
/tmp/druid/extensions/druid-it-tools/
Review Comment:
Can we make loading this testing tool version optional ?
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/categories/BackwardIncompatibility.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.testsEx.categories;
+
+public class BackwardIncompatibility
Review Comment:
```suggestion
public class BackwardCompatibility
```
Nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
