findingrish commented on code in PR #13967:
URL: https://github.com/apache/druid/pull/13967#discussion_r1694235568
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -269,11 +309,14 @@ private void serverAddedSegment(final DruidServerMetadata
server, final DataSegm
// in theory we could probably just filter this to ensure we don't put
ourselves in here, to make broker tree
// query topologies, but for now just skip all brokers, so we don't
create some sort of wild infinite query
// loop...
+ boolean runCallBack = false;
if (!server.getType().equals(ServerType.BROKER)) {
log.debug("Adding segment[%s] for server[%s]", segment, server);
+
ServerSelector selector = selectors.get(segmentId);
if (selector == null) {
- selector = new ServerSelector(segment, tierSelectorStrategy);
+ // if unavailableSegmentDetection is enabled, segment is not
queryable unless added by coordinator
Review Comment:
> Seems like queryable is going to be false here always, regardless of
whether unavailable segment detection is enabled? Is that intentional?
`queryable` state in `ServerSelector` is true for a used segment which has
been once loaded on a historical server.
This field is set when segment is polled from the Coordinator.
Unavailability of a segment marked as `queryable` would be counted as an
unavailable segment when the feature is turned on.
If the feature is turned off, this field doesn't have any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
