findingrish commented on PR #13967: URL: https://github.com/apache/druid/pull/13967#issuecomment-2254602111
> How will this design work when there are used segments but have zero replication factor? If a segment is created with replication factor of 0, it will never be loaded onto any historical. Consequently, the segment wouldn't be marked as `loaded` and will not be added to the Broker's timeline. This behaviour is as expected. If a segment's replication factor is changed to 0 after it has been loaded, the segment will remain in the Broker's timeline with `queryable` status, resulting in queries finding the segment to be unavailable. This problem can be fixed by detecting the replication factor change in the Coordinator and thereafter send a change event to the Broker to remove the segment metadata from Broker's timeline. Now consider the scenario where the segment's replication factor changes to non-zero, and the Broker receives this updated metadata from the Coordinator before the segment is reported as loaded by any Historical, queries in this period will find this segment to be unavailable. Is this behaviour correct? Or should the `loaded` field of the segment be dynamically adjusted when it is marked as cold? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
