github-advanced-security[bot] commented on code in PR #16825:
URL: https://github.com/apache/druid/pull/16825#discussion_r1698526872
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQComplexGroupByTest.java:
##########
@@ -416,4 +431,90 @@
))
.verifyResults();
}
+
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void testCountDistinctOnNestedData(String contextName, Map<String,
Object> context)
Review Comment:
## Useless parameter
The parameter 'contextName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7657)
##########
processing/src/main/java/org/apache/druid/frame/field/ComplexFieldReader.java:
##########
@@ -150,12 +150,16 @@
private final Memory memory;
private final ReadableFieldPointer fieldPointer;
private final ComplexMetricSerde serde;
+ @SuppressWarnings("rawtypes")
+ private final Class clazz;
private Selector(Memory memory, ReadableFieldPointer fieldPointer,
ComplexMetricSerde serde)
{
this.memory = memory;
this.fieldPointer = fieldPointer;
this.serde = serde;
+ //noinspection deprecation
+ this.clazz = serde.getObjectStrategy().getClazz();
Review Comment:
## Deprecated method or constructor invocation
Invoking [ComplexMetricSerde.getObjectStrategy](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7655)
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/ComplexFrameColumnReader.java:
##########
@@ -138,6 +139,8 @@
{
this.frame = frame;
this.serde = serde;
+ //noinspection deprecation
+ this.clazz = serde.getObjectStrategy().getClazz();
Review Comment:
## Deprecated method or constructor invocation
Invoking [ComplexMetricSerde.getObjectStrategy](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7656)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
