cryptoe commented on code in PR #16835:
URL: https://github.com/apache/druid/pull/16835#discussion_r1701327903
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -662,8 +668,10 @@ private static <T, QueryType extends Query<T>> DataSource
toInlineDataSource(
final AtomicBoolean cannotMaterializeToFrames,
final int limit,
long memoryLimit,
- boolean useNestedForUnknownTypeInSubquery,
- SubqueryCountStatsProvider subqueryStatsProvider
+ final boolean useNestedForUnknownTypeInSubquery,
+ final SubqueryCountStatsProvider subqueryStatsProvider,
+ final boolean emitMetrics,
Review Comment:
Could you please java doc why this dryRun flag is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
