clintropolis commented on code in PR #16533:
URL: https://github.com/apache/druid/pull/16533#discussion_r1702431318
##########
processing/src/main/java/org/apache/druid/segment/Cursor.java:
##########
@@ -35,11 +36,45 @@
*/
public interface Cursor
{
+ /**
+ * Get a {@link ColumnSelectorFactory} whose selectors will be backed by the
row values at the current position of
+ * the cursor
+ */
ColumnSelectorFactory getColumnSelectorFactory();
- DateTime getTime();
+
+ /**
+ * Advance to the next row in the cursor, checking if thread has been
interrupted after advancing and possibly
+ * throwing {@link QueryInterruptedException} if so
+ */
void advance();
+
+ /**
+ * Advance to the next row in the cursor
+ */
void advanceUninterruptibly();
+
+ /**
+ * Check if there are any additional rows in the cursor
+ */
boolean isDone();
+
+ /**
+ * Check if there are any additional rows in the cursor, or if the thread
has been interrupted
+ */
boolean isDoneOrInterrupted();
+
+ /**
+ * Mark a position on the cursor which can recalled with {@link
#resetToMark()}
+ */
+ void mark(DateTime mark);
Review Comment:
updated javadocs to try to clarify the contract and usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
