kfaraz commented on code in PR #16829:
URL: https://github.com/apache/druid/pull/16829#discussion_r1703489325


##########
docs/operations/metrics.md:
##########
@@ -297,6 +297,8 @@ If the JVM does not support CPU time measurement for the 
current thread, `ingest
 |`worker/taskSlot/used/count`|Number of busy task slots on the reporting 
worker per emission period. This metric is only available if the 
`WorkerTaskCountStatsMonitor` module is included.| `category`, 
`workerVersion`|Varies|
 |`worker/task/assigned/count`|Number of tasks assigned to an indexer per 
emission period. This metric is only available if the 
`WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies|
 |`worker/task/completed/count`|Number of tasks completed by an indexer per 
emission period. This metric is only available if the 
`WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies|
+|`indexer/task/failed/count`|Number of tasks failed on an indexer per emission 
period. This metric is only available if the `WorkerTaskCountStatsMonitor` 
module is included.|`dataSource`|Varies|
+|`indexer/task/success/count`|Number of tasks succeeded on an indexer per 
emission period. This metric is only available if the 
`WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies|

Review Comment:
   I think it is okay to emit the metric of the same name from indexer too, 
since we are already emitting `worker/task/assigned/count`, 
`worker/task/completed/count` and `worker/task/running/count` from indexers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to