adithyachakilam commented on code in PR #16844:
URL: https://github.com/apache/druid/pull/16844#discussion_r1707210970
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorStateManager.java:
##########
@@ -155,11 +155,10 @@ public synchronized void maybeSetState(State
proposedState)
return;
}
- // if we're trying to switch to a healthy steady state (i.e. RUNNING or
SUSPENDED) or IDLE state but haven't had a successful run
+ // if we're trying to switch to a healthy steady state (i.e. RUNNING or
SUSPENDED) but haven't had a successful run
// yet, refuse to switch and prefer the more specific states used for
first run (CONNECTING_TO_STREAM,
// DISCOVERING_INITIAL_TASKS, CREATING_TASKS, etc.)
- if ((healthySteadyState.equals(proposedState) ||
BasicState.IDLE.equals(proposedState))
Review Comment:
`SeekableStreamSupervisor.runInternal` call our newly introduced method even
before than the `markRunFinished`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
