adithyachakilam commented on code in PR #16844:
URL: https://github.com/apache/druid/pull/16844#discussion_r1707220785
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1260,6 +1260,30 @@ public void tryInit()
}
}
+ public boolean markSuperviosrIdleIfInactiveOnStartup()
Review Comment:
Since we are comparing offsets from metadata and also running this logic
only on the very first run, I thought to separate this out to different method.
Also, `checkIfStreamInactiveAndTurnSupervisorIdle` is invoked at the end of
`runInternal` rather than the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
