kgyrtkirk commented on code in PR #16798:
URL: https://github.com/apache/druid/pull/16798#discussion_r1707335745
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -544,18 +545,20 @@ public SqlStatementFactory statementFactory()
* This is an intermediate solution: the ultimate solution is to create
things
* in Guice itself.
*/
- private class TestSetupModule implements DruidModule
Review Comment:
I also didin't liked that `super` constructor call - its not that usefull to
have this class; so I've removed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
