clintropolis opened a new pull request, #16863:
URL: https://github.com/apache/druid/pull/16863
### Description
changes:
* Adds new `CompressedComplexColumn`, `CompressedComplexColumnSerializer`,
`CompressedComplexColumnSupplier` based on `CompressedVariableSizedBlobColumn`
used by JSON columns
* Adds `IndexSpec.complexMetricCompression` which can be used to specify
compression for the generic compressed complex column. Defaults to uncompressed
because compressed columns are not backwards compatible.
* Adds new definition of `ComplexMetricSerde.getSerializer` which accepts an
`IndexSpec` argument when creating a serializer. The old signature has been
marked `@Deprecated` and has a default implementation that returns `null`, but
it will be used by the default implementation of the new version if it is
implemented to return a non-null value. The default implementation of the new
method will use a `CompressedComplexColumnSerializer` if
`IndexSpec.complexMetricCompression` is not null/none/uncompressed, or will use
`LargeColumnSupportedComplexColumnSerializer` otherwise.
* Removed all duplicate generic implementations of
`ComplexMetricSerde.getSerializer` and `ComplexMetricSerde.deserializeColumn`
into default implementations `ComplexMetricSerde` instead of being copied all
over the place. The default implementation of `deserializeColumn` will check if
the first byte indicates that the new compression was used, otherwise will use
the `GenericIndexed` based supplier.
* Complex columns with custom serializers/deserializers are unaffected and
may continue doing whatever it is they do, either with specialized compression
or whatever else, this new stuff is just to provide generic implementations
built around `ObjectStrategy`. This should not preclude further specializing
specific complex types in the future, this is just providing a generic base way
to have compression to save some space.
#### Release note
_todo_
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
