clintropolis commented on code in PR #16863:
URL: https://github.com/apache/druid/pull/16863#discussion_r1730417197
##########
processing/src/main/java/org/apache/druid/segment/data/ObjectStrategy.java:
##########
@@ -59,6 +60,19 @@ default boolean canCompare()
return true;
}
+ /**
+ * Whether the {@link #fromByteBuffer(ByteBuffer, int)}, {@link
#fromByteBufferWithSize(ByteBuffer)}, and
+ * {@link #fromByteBufferSafe(ByteBuffer, int)} methods return an object
that may retain a reference to the provided
+ * {@link ByteBuffer}. If a reference is sometimes retained, this method
returns true. It returns false if, and only
Review Comment:
ah, yeah i suppose it does need to clarify that it retains the same memory,
will update
##########
processing/src/main/java/org/apache/druid/segment/data/ObjectStrategy.java:
##########
@@ -59,6 +60,19 @@ default boolean canCompare()
return true;
}
+ /**
+ * Whether the {@link #fromByteBuffer(ByteBuffer, int)}, {@link
#fromByteBufferWithSize(ByteBuffer)}, and
+ * {@link #fromByteBufferSafe(ByteBuffer, int)} methods return an object
that may retain a reference to the provided
+ * {@link ByteBuffer}. If a reference is sometimes retained, this method
returns true. It returns false if, and only
Review Comment:
ah, yeah i suppose it does need to clarify that it means retains the same
memory, will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
