kgyrtkirk commented on code in PR #16865:
URL: https://github.com/apache/druid/pull/16865#discussion_r1708885839
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -326,6 +326,9 @@ public Closeable goOrContinue(Closeable continuationObject,
Receiver receiver)
*/
private void runAllOpsOnMultipleRac(ArrayList<RowsAndColumns> listOfRacs)
{
+ if (listOfRacs.isEmpty()) {
Review Comment:
I don't think we should workaround this with such an `if`
this will not fix `ConcatRowsAndColumns` - or changes its contract ; so the
problem lives on...but will not be encountered "here"...
please:
* add testcase which reproduces the issue to `RowsAndColumnsTestBase`
* run `ConcatRowsAndColumnsTest`
* fix `ConcatRowsAndColumns`
* you may optionally also remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
