kgyrtkirk commented on code in PR #16865:
URL: https://github.com/apache/druid/pull/16865#discussion_r1708950629


##########
processing/src/main/java/org/apache/druid/query/rowsandcols/ConcatRowsAndColumns.java:
##########
@@ -92,6 +92,9 @@ public Column findColumn(String name)
     if (columnCache.containsKey(name)) {
       return columnCache.get(name);
     } else {
+      if (racBuffer.isEmpty()) {

Review Comment:
   while we are at this; can you also add a `Preconditions` check to the 
constructor?
   
   please also check&test other possibly affected methods as well ; I guess 
`getColumnNames()` would throw the same error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to