clintropolis commented on PR #16867: URL: https://github.com/apache/druid/pull/16867#issuecomment-2277045287
or i guess an alternative version of my question, if we are going to have a larger test file like this and run a bunch of queries against it, why wouldn't we want to run these as actual integration tests against a real docker cluster instead of as unit tests? I ask since the scaffolding used by the calcite query tests somewhat mimics the behavior of a real cluster but is missing a bunch of parts that using a real cluster would have. The calcite test runner stuff is decent for testing functional correctness, but is not provide the coverage using a real cluster would, since its missing all of the stuff like segment merging on historicals, wire serialization, etc. If these tests don't provide some functional coverage that isn't already covered, i think they would be better suited as integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
