abhishekagarwal87 commented on code in PR #16867: URL: https://github.com/apache/druid/pull/16867#discussion_r1775063274
########## quidem-ut/README.md: ########## @@ -22,6 +22,9 @@ Enables to write sql level tests easily. Can be used to write tests against existing test backends (ComponentSupplier) - by doing so the testcases can be moved closer to the exercised codes. +These tests might come from real usages of Druid by some external tool - by utilizing the capture mode of this module iq tests could be captured and validated later that they retain their results. +By adding tests for those here could act as an early warning that something might have changed. Review Comment: ```suggestion By adding tests for those here could act as an early warning that something might have changed. The `kttm_*` tests contains queries that were recorded while using a BI tool that is issuing druid queries behind the scenes. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
