findingrish opened a new pull request, #16873:
URL: https://github.com/apache/druid/pull/16873
### Issue
Schema from cold segments wasn't getting reflected in the datasource schema.
The problem turned out to be in the refresh thread, it ran only once instead
of running periodically.
Apart from fixing the issue and adding UTs, this PR also adds some metrics
to monitor cold schema refresh process.
### Release Notes
Add followings metrics to monitor cold schema refresh.
```
metadatacache/cold/segment/count -> Number of cold segment per datasource.
metadatacache/cold/refresh/count -> Number of cold segments with cached
schema per datasource.
metadatacache/cold/process/time -> Time taken in milliseconds to process
cold segments.
```
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
