FrankChen021 commented on code in PR #16871: URL: https://github.com/apache/druid/pull/16871#discussion_r1713115616
########## docs/querying/sql-functions.md: ########## @@ -1519,27 +1655,69 @@ Alias for [`LENGTH`](#length). ## STRPOS -`STRPOS(<CHARACTER>, <CHARACTER>)` +Returns the one-based index position of a substring within an expression. Review Comment: what if the substring is not found in the given expression? ########## docs/querying/sql-functions.md: ########## @@ -1706,17 +1884,36 @@ Takes the difference between two timestamps, returning the results in the given **Function type:** [JSON](sql-json-functions.md) `TO_JSON_STRING(expr)` - +ƒ() Review Comment: what is this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
