LakshSingla commented on PR #16887: URL: https://github.com/apache/druid/pull/16887#issuecomment-2287848660
> Is it possible to do the logic in the peon itself rather than in the runners I looked at the following approaches but didn't find a suitable one: 1. We can't modify `DruidProcessingConfig`, since that's shared by historicals etc. as well, and `Task.class` that we require for checking if `task.supportsQueries` can't be added to the module (since `Task.class` resides in the indexing module, which isn't a dep of druid-server where the former class resides). 2. I was looking for a way to override the providers for the `CliPeon`, and while I can do that ([checkout the last commit](https://github.com/apache/druid/pull/16887/commits/83085d48a21d3466a26c012175d96da744a83de3)), I need to duplicate some of the `DruidProcessingModule` code too - in case the task supportsQueries. I didn't find a way to conditionally override the binding (since the Task instance isn't present when we add our bindings), or access the overridden bindings at the runtime before overriding them. LMK if there's a way that I am missing. Otherwise, there's some duplication in the `CliPeon` code, which we'd need to keep in sync with the `DruidProcessingModule` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
