cryptoe commented on code in PR #16887:
URL: https://github.com/apache/druid/pull/16887#discussion_r1715305897


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java:
##########
@@ -364,6 +364,13 @@ public TaskStatus call()
                         
command.addSystemProperty("druid.indexer.task.baseTaskDir", 
storageSlot.getDirectory().getAbsolutePath());
                         
command.addSystemProperty("druid.indexer.task.tmpStorageBytesPerTask", 
storageSlot.getNumBytes());
 
+                        if (!task.supportsQueries()) {
+                          // Processing threads, processing buffers and 
merging buffers are not required on tasks which

Review Comment:
   Nit: could you add the same comment in k8 task adapter as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to