pjain1 opened a new pull request, #16895:
URL: https://github.com/apache/druid/pull/16895
### Description
If timestampResultField is set, we must include a copy of the timestamp in
the result extracted from cache as this is used by the SQL layer when it
generates a Timeseries query for a group-by-time-floor SQL query. The SQL layer
expects the result of the time-floor to have a specific name that is not going
to be __time.
This is already done for no cache case but missing when pulling results from
cache.
#### Release note
<!-- Give your best effort to summarize your changes in a couple of
sentences aimed toward Druid users.
Fixes bug in pulling timeseries cache results having time_floor dimension
-->
<hr>
##### Key changed/added classes in this PR
* `TimeseriesQueryQueryToolChest`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
