kgyrtkirk commented on PR #16895:
URL: https://github.com/apache/druid/pull/16895#issuecomment-2309838950
thank you for fixing this - looks good!
instead of leaving the coverage failures; can you add
`ImmutableMap.of(TimeseriesQuery.CTX_TIMESTAMP_RESULT_FIELD, "ts_field")` to
`TimeseriesQueryQueryToolChestTest#testCaching` ?
<details>
<summary>patch</summary>
```
@@ -97,7 +99,8 @@ public class TimeseriesQueryQueryToolChestTest
),
ImmutableList.of(new ConstantPostAggregator("post", 10)),
0,
- null
+// null
+ ImmutableMap.of(TimeseriesQuery.CTX_TIMESTAMP_RESULT_FIELD,
"ts_field")
)
);
@@ -106,6 +109,7 @@ public class TimeseriesQueryQueryToolChestTest
DateTimes.utc(123L),
new TimeseriesResultValue(
ImmutableMap.of(
+ "ts_field", 123L,
"metric1", 2,
"metric0", 3,
"complexMetric", new SerializablePairLongString(123L,
"val1")
@@ -130,6 +134,7 @@ public class TimeseriesQueryQueryToolChestTest
DateTimes.utc(123L),
new TimeseriesResultValue(
ImmutableMap.of(
+ "ts_field", 123L,
"metric1", 2,
"metric0", 3,
"complexMetric", "val1",
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
