techdocsmith commented on code in PR #16883: URL: https://github.com/apache/druid/pull/16883#discussion_r1718816771
########## docs/querying/granularities.md: ########## @@ -30,7 +30,7 @@ sidebar_label: "Granularities" [SQL documentation](sql-scalar.md#date-and-time-functions). ::: -Granularity determines how to bucket data across the time dimension, or how to aggregate data by hour, day, minute, etc. +Granularity determines how to bucket data across the time dimension, or how to aggregate data by hour, day, minute, etc and defines how it is stored. Review Comment: ```suggestion Granularity determines how to bucket data across the time dimension, or how to aggregate data by hour, day, minute, etc and defines how it is stored. The granularity formats here apply also to `segmentGranularity` and `queryGranularity` in the `granularitySpec` section of the the [ingestion spec](../ingestion/ingestion-spec.md#granularityspec). ``` ########## docs/design/storage.md: ########## @@ -67,7 +67,7 @@ On the Coordinator / Historical side: Segments all have a four-part identifier with the following components: - Datasource name. -- Time interval (for the time chunk containing the segment; this corresponds to the `segmentGranularity` specified at ingestion time). +- Time interval (for the time chunk containing the segment; this corresponds to the `segmentGranularity` specified at ingestion time the same as for [query granularity](../querying/granularities.md)). Review Comment: ```suggestion - Time interval for the time chunk containing the segment; this corresponds to the `segmentGranularity` specified at ingestion time. Uses the same format as [query granularity](../querying/granularities.md). ``` avoid parens. minor ########## docs/ingestion/ingestion-spec.md: ########## @@ -324,7 +324,7 @@ An example `granularitySpec` is: } ``` -A `granularitySpec` can have the following components: +A `granularitySpec` uses the same format as [query granularity](../querying/granularities.md) can have the following components: Review Comment: ```suggestion A `granularitySpec` can have the following components: ``` wrong spot for this :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
