techdocsmith commented on code in PR #16883: URL: https://github.com/apache/druid/pull/16883#discussion_r1728092434
########## docs/ingestion/ingestion-spec.md: ########## @@ -301,15 +301,15 @@ An example `metricsSpec` is: ### `granularitySpec` -The `granularitySpec` is located in `dataSchema` → `granularitySpec` and is responsible for configuring -the following operations: +The `granularitySpec`, located in `dataSchema` → `granularitySpec`, specifies the following: -1. Partitioning a datasource into [time chunks](../design/storage.md) (via `segmentGranularity`). -2. Truncating the timestamp, if desired (via `queryGranularity`). -3. Specifying which time chunks of segments should be created, for batch ingestion (via `intervals`). -4. Specifying whether ingestion-time [rollup](./rollup.md) should be used or not (via `rollup`). +1. `segmentGranularity` to partitioning a datasource into [time chunks](../design/storage.md). +2. `queryGranularity` to optionally truncate the timestamp. +3. `intervals` to define the time chunks of segments to create for batch ingestion. +4. `rollup` to enable ingestion-time [rollup](./rollup.md) or not. Other than `rollup`, these operations are all based on the [primary timestamp](./schema-model.md#primary-timestamp). +Use the format in [Query granularities] to specify both `segmentGranualarity` and `queryGranularity`. Review Comment: ```suggestion Use the format from [Query granularities] to specify both `segmentGranualarity` and `queryGranularity`. ``` nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
