adithyachakilam commented on code in PR #16844:
URL: https://github.com/apache/druid/pull/16844#discussion_r1710416299
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java:
##########
@@ -408,13 +408,10 @@ public SeekableStreamIndexTaskClient<KafkaTopicPartition,
Long> build(
autoscaler.start();
supervisor.runInternal();
Thread.sleep(1000);
- supervisor.runInternal();
verifyAll();
int taskCountAfterScale = supervisor.getIoConfig().getTaskCount();
Assert.assertEquals(2, taskCountAfterScale);
- Assert.assertEquals(SupervisorStateManager.BasicState.IDLE,
supervisor.getState());
Review Comment:
This is an invalid test. There are no actuals tasks running to consume the
lag and go to idle. It used to work previously because reporting thread is yet
to be executed before the completion of test and `computeLag` implied null as
`0` lag. But with us now updating the lag proactively this fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
