kfaraz commented on code in PR #16887:
URL: https://github.com/apache/druid/pull/16887#discussion_r1721217137
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -205,7 +223,67 @@ public void configure(Properties properties)
protected List<? extends Module> getModules()
{
return ImmutableList.of(
- new DruidProcessingModule(),
+ Modules.override(new DruidProcessingModule()).with(
+ new Module()
+ {
+ @Override
+ public void configure(Binder binder)
+ {
+
+ }
+
+ @Provides
+ @ManageLifecycle
+ public QueryProcessingPool getProcessingExecutorPool(
+ Task task,
+ DruidProcessingConfig config,
+ ExecutorServiceMonitor executorServiceMonitor,
+ Lifecycle lifecycle
+ )
+ {
+ if (!task.supportsQueries()) {
+ return new ForwardingQueryProcessingPool(Execs.dummy());
+ }
+ return new MetricsEmittingQueryProcessingPool(
+ PrioritizedExecutorService.create(
+ lifecycle,
+ config
+ ),
+ executorServiceMonitor
+ );
Review Comment:
Also, I wish the `QueryProcessingPool` didn't extend
`ListeningExecutorService`.
It would make for a cleaner interface and it would have been much easier to
write dummy implementations.
Are the executor service methods ever called on the query processing pool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
