LakshSingla commented on PR #16887:
URL: https://github.com/apache/druid/pull/16887#issuecomment-2299584157

   @kfaraz 
   It seems the overriding the provides methods isn't allowed by Guice. 
Unfortunately, using `Modules.overrides()` is the only way. Going ahead with 
the `NoopQueryProcessingPool` suggestion along with reverting the latest 
commit. 
   ```
     8 1) Overriding @Provides methods is not allowed.
     9         @Provides method: 
org.apache.druid.guice.DruidProcessingModule.getIntermediateResultsPool()
    10         overridden by: 
org.apache.druid.guice.PeonProcessingModule.getIntermediateResultsPool()
    11   at 
com.google.inject.internal.ProviderMethodsModule.getProviderMethods(ProviderMethodsModule.java:163)
    12
    13 2) Overriding @Provides methods is not allowed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to