clintropolis commented on code in PR #16698:
URL: https://github.com/apache/druid/pull/16698#discussion_r1722499566
##########
processing/src/main/java/org/apache/druid/segment/writeout/SegmentWriteOutMediumFactory.java:
##########
@@ -30,6 +30,7 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type", defaultImpl =
TmpFileSegmentWriteOutMediumFactory.class)
@JsonSubTypes(value = {
@JsonSubTypes.Type(name = "tmpFile", value =
TmpFileSegmentWriteOutMediumFactory.class),
+ @JsonSubTypes.Type(name = "legacyTmpFile", value =
LegacyTmpFileSegmentWriteOutMediumFactory.class),
Review Comment:
nit: i think putting `legacy` in the names of config stuff is not usually
great to do since other things could become legacy too i suppose, but i don't
feel super strongly either way i guess. We should maybe update docs to indicate
that this exists?
https://druid.apache.org/docs/latest/configuration/#segmentwriteoutmediumfactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
