gianm commented on code in PR #16912:
URL: https://github.com/apache/druid/pull/16912#discussion_r1722824741
##########
processing/src/main/java/org/apache/druid/frame/file/FrameFile.java:
##########
@@ -186,7 +186,7 @@ static FrameFile open(
// Verify minimum file length.
if (fileLength <
FrameFileWriter.MAGIC.length + FrameFileWriter.TRAILER_LENGTH +
Byte.BYTES /* MARKER_NO_MORE_FRAMES */) {
- throw new IOE("File [%s] is too short (size = [%,d])", file,
fileLength);
+ throw new IOE("File[%s] is too short (size = [%,d])", file,
fileLength);
Review Comment:
Hmm, I can't really think of a good admin, user, or operator oriented
message for this condition. It probably indicates some bug or data corruption.
They probably all need to be "developer" messages. Although I think "developer"
DruidExceptions get wrapped around random exceptions automatically… perhaps
they're ok the way they are? Please LMK if you had something else in mind
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
