clintropolis opened a new pull request, #16942:
URL: https://github.com/apache/druid/pull/16942
Fixes inconsistency in `IPV4_PARSE` function SQL return type, which prior to
this PR was specified as `INTEGER` while the native layer uses `LONG`. Because
of this, `ipv4_parse('192.168.0.1')` would return -1062731775 since java only
has signed integers, while the long number of the native layer is 3232235521.
We could probably consider casting the negative arguments in the native
layer into an int and then the bits back into a long to try to turn something
like -1062731775 into 3232235521 so it isn't discarded as a null, but I didn't
make that change at this time since there would be some performance cost to it,
and I'm not sure if it should work anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
