kfaraz commented on code in PR #16768:
URL: https://github.com/apache/druid/pull/16768#discussion_r1728369344
##########
services/src/main/java/org/apache/druid/cli/CliRouter.java:
##########
@@ -101,6 +102,7 @@ protected List<? extends Module> getModules()
JsonConfigProvider.bind(binder, "druid.router",
TieredBrokerConfig.class);
JsonConfigProvider.bind(binder, "druid.router.avatica.balancer",
AvaticaConnectionBalancer.class);
JsonConfigProvider.bind(binder, "druid.router.managementProxy",
ManagementProxyConfig.class);
+ JsonConfigProvider.bind(binder, "druid.compaction.supervisors",
CompactionSupervisorsConfig.class);
Review Comment:
Created a constant. Creating a separate module seems like overkill to bind
just one config. If there are more objects that need to be bound in the future,
we can create a separate module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
