kfaraz commented on code in PR #16768: URL: https://github.com/apache/druid/pull/16768#discussion_r1728348593
########## server/src/main/java/org/apache/druid/server/compaction/PriorityBasedSegmentSearchPolicy.java: ########## Review Comment: All policies are at interval level since we can either choose to compact interval or not compact it at all. (The current state of compaction in an interval can be partial though, if segments were appended to that interval after a prior round of compaction.) The object `SegmentsToCompact` represents all segments to compact in a single interval. Do you think some rename of the base policy would help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
