clintropolis opened a new pull request, #16985:
URL: https://github.com/apache/druid/pull/16985
### Description
Follow-up to finish what #16533 and #16849 started, moving everything
completely away from `StorageAdapter`.
changes:
* `CursorHolderFactory` has been renamed to `CursorFactory` and moved off of
`StorageAdapter`, instead fetched directly from the segment via
`asCursorFactory`. The previous deprecated `CursorFactory` interface has been
merged into `StorageAdapter`
* `StorageAdapter` is no longer used by any engines or tests and has been
marked as deprecated with default implementations of all methods that throw
exceptions indicating the new methods to call instead
* `StorageAdapter` methods not covered by `CursorFactory`
(`CursorHolderFactory` prior to this change) have been moved into interfaces
which are retrieved by `Segment.as`, the primary classes are the previously
existing `Metadata`, as well as new interfaces `PhysicalSegmentInspector` and
`TopNOptimizationInspector`
* added `UnnestSegment` and `FilteredSegment` that extend
`WrappedSegmentReference` since their `StorageAdapter` implementations were
previously provided by `WrappedSegmentReference`
* added `PhysicalSegmentInspector` which covers some of the previous
`StorageAdapter` functionality which was primarily used for segment metadata
queries and other metadata uses, and is implemented for `QueryableIndexSegment`
and `IncrementalIndexSegment`
* added `TopNOptimizationInspector` to cover the oddly specific
`StorageAdapter.hasBuiltInFilters` implementation, which is implemented for
`HashJoinSegment`, `UnnestSegment`, and `FilteredSegment`
* Updated all engines and tests to no longer use `StorageAdapter`, deleted
all `StorageAdapter` implementations
#### Release note
_tbd_
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
